Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds aliasMethod deprecation #269

Merged
merged 2 commits into from
Feb 2, 2019
Merged

Adds aliasMethod deprecation #269

merged 2 commits into from
Feb 2, 2019

Conversation

pzuraq
Copy link
Contributor

@pzuraq pzuraq commented Jan 31, 2019

@sivakumar-kailasam sivakumar-kailasam temporarily deployed to deprecations-app-stagin-pr-269 January 31, 2019 21:42 Inactive
Copy link
Contributor

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you thought about suggesting this:

import EmberObject from '@ember/object';
 function logFoo(obj) {
}
 export default EmberObject.extend({
  foo: 123,
  bar() {
    console.log(obj.foo);
  },
  baz() {
    return this.bar(...arguments);
  },
});

Seems "better" by some subjective sense, thoughts?

@pzuraq
Copy link
Contributor Author

pzuraq commented Feb 1, 2019

Can update to that instead

@rwjblue rwjblue merged commit 67023c5 into master Feb 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the deprecate-alias-method branch February 2, 2019 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants