Deprecation guide for jQuery removal #255
Conversation
simonihmig
force-pushed
the
jquery-apis
branch
from
2060bbb
to
ea120ca
Compare
|
@locks updated after your review, thanks! |
content/ember/v3/jquery-apis.md
Outdated
| since: '3.8' | ||
| --- | ||
|
|
||
| As jQuery will be removed from Ember by default, APIs that are coupled to jQuery have been deprecated. |
There was a problem hiding this comment.
| As jQuery will be removed from Ember by default, APIs that are coupled to jQuery have been deprecated. | |
| As of Ember 3.2.0, Ember no longer requires that all applications include jQuery, therefore APIs that are coupled to jQuery have been deprecated. |
There was a problem hiding this comment.
I believe making jQuery optional was implemented for Ember.js 3.3, wasn't it?
But there was another thing, IIRC the 3.3 release of Ember CLI was postponed (making it 3.4), which included the necessary changes required by the (first) RFC. So we referred to 3.4 as the version which made jQuery optional, as this was the least confusing option for users (who usually have Ember & CLI in lockstep). This is at least what the Guides say: https://guides.emberjs.com/release/configuring-ember/optional-features/#toc_jquery-integration
So I changed this to 3.4.0 now, hope this is fine?
|
The changes I suggested are actually pretty minor edits to the original prose, looks like a bunch more when viewed here... |
Co-Authored-By: simonihmig <[email protected]>
simonihmig
force-pushed
the
jquery-apis
branch
from
9be346a
to
59d5c4c
Compare
@rwjblue Thanks! Applied your suggestions, reads much better now. Just one remark left, see my other comment... |
|
Oh, and just updated the |
As per RFC386
Please check twice, as I am not a native speaker! 😉
Also whether the message/tone seems appropriate! /cc @rwjblue @tomdale