Skip to content

Commit

Permalink
Deprecate route router
Browse files Browse the repository at this point in the history
  • Loading branch information
cibernox committed Mar 19, 2018
1 parent 26394ab commit b96b1d9
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 52 deletions.
20 changes: 20 additions & 0 deletions content/ember/v3/route-router.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
id: ember-routing.route-router
title: Private property `Route.router` has been renamed to `Route._router`
until: '3.5.0'
since: '3.2'
---

The `Router#route` private API has been renamed to `Router#_route` to avoid collisions with user-defined
properties or methods.
If you want access to the router, you are probably better served injecting the router service into
the route like this:

```javascript
import Route from '@ember/routing/route';
import { inject as service } from '@ember/service';

export default Route.extend({
router: service()
});
```
54 changes: 2 additions & 52 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2314,18 +2314,6 @@ core-js@^2.4.0, core-js@^2.4.1, core-js@^2.5.0:
version "2.5.3"
resolved "https://registry.yarnpkg.com/core-js/-/core-js-2.5.3.tgz#8acc38345824f16d8365b7c9b4259168e8ed603e"

[email protected]:
version "2.0.6"
resolved "https://registry.yarnpkg.com/core-object/-/core-object-2.0.6.tgz#60134b9c40ff69b27bc15e82db945e4df782961b"
dependencies:
chalk "^1.1.3"

core-object@^2.0.0:
version "2.1.1"
resolved "https://registry.yarnpkg.com/core-object/-/core-object-2.1.1.tgz#4b7a5f1edefcb1e6d0dcb58eab1b9f90bfc666a8"
dependencies:
chalk "^1.1.3"

core-object@^3.1.3:
version "3.1.5"
resolved "https://registry.yarnpkg.com/core-object/-/core-object-3.1.5.tgz#fa627b87502adc98045e44678e9a8ec3b9c0d2a9"
Expand Down Expand Up @@ -2379,7 +2367,7 @@ d@1:
dependencies:
es5-ext "^0.10.9"

dag-map@^2.0.1, dag-map@^2.0.2:
dag-map@^2.0.2:
version "2.0.2"
resolved "https://registry.yarnpkg.com/dag-map/-/dag-map-2.0.2.tgz#9714b472de82a1843de2fba9b6876938cab44c68"

Expand Down Expand Up @@ -2562,10 +2550,6 @@ dot-prop@^4.1.0:
dependencies:
is-obj "^1.0.0"

dotenv@^1.2.0:
version "1.2.0"
resolved "https://registry.yarnpkg.com/dotenv/-/dotenv-1.2.0.tgz#7cd73e16e07f057c8072147a5bc3a8677f0ab5c6"

ecc-jsbn@~0.1.1:
version "0.1.1"
resolved "https://registry.yarnpkg.com/ecc-jsbn/-/ecc-jsbn-0.1.1.tgz#0fc73a9ed5f0d53c38193398523ef7e543777505"
Expand Down Expand Up @@ -2689,40 +2673,6 @@ ember-cli-dependency-checker@^2.1.0:
resolve "^1.5.0"
semver "^5.3.0"

[email protected]:
version "1.1.1"
resolved "https://registry.yarnpkg.com/ember-cli-deploy-build/-/ember-cli-deploy-build-1.1.1.tgz#de515b04536a569f42626ef28aea139f32ef00e8"
dependencies:
chalk "^1.0.0"
ember-cli-deploy-plugin "^0.2.1"
glob "^7.1.1"
rsvp "^3.5.0"

ember-cli-deploy-plugin@^0.2.1:
version "0.2.9"
resolved "https://registry.yarnpkg.com/ember-cli-deploy-plugin/-/ember-cli-deploy-plugin-0.2.9.tgz#a3d395b8adad7ef68d8bacdd0b0f4a61bcf9e651"
dependencies:
chalk "^1.0.0"
core-object "2.0.6"
lodash.clonedeep "^4.5.0"

ember-cli-deploy-progress@^1.3.0:
version "1.3.0"
resolved "https://registry.yarnpkg.com/ember-cli-deploy-progress/-/ember-cli-deploy-progress-1.3.0.tgz#18663deed25b4d5397476332f25eed3c3fdf225a"

ember-cli-deploy@^1.0.2:
version "1.0.2"
resolved "https://registry.yarnpkg.com/ember-cli-deploy/-/ember-cli-deploy-1.0.2.tgz#9ab39188c882b57937418db5b3da6fc65b16b916"
dependencies:
chalk "^1.1.3"
core-object "^2.0.0"
dag-map "^2.0.1"
dotenv "^1.2.0"
ember-cli-deploy-progress "^1.3.0"
lodash "^4.0.0"
rsvp "^3.3.3"
silent-error "^1.0.0"

ember-cli-eslint@^4.2.3:
version "4.2.3"
resolved "https://registry.yarnpkg.com/ember-cli-eslint/-/ember-cli-eslint-4.2.3.tgz#2844d3f5e8184f19b2d7132ba99eb0b370b55598"
Expand Down Expand Up @@ -5322,7 +5272,7 @@ lodash.castarray@^4.4.0:
version "4.4.0"
resolved "https://registry.yarnpkg.com/lodash.castarray/-/lodash.castarray-4.4.0.tgz#c02513515e309daddd4c24c60cfddcf5976d9115"

lodash.clonedeep@^4.3.2, lodash.clonedeep@^4.4.1, lodash.clonedeep@^4.5.0:
lodash.clonedeep@^4.3.2, lodash.clonedeep@^4.4.1:
version "4.5.0"
resolved "https://registry.yarnpkg.com/lodash.clonedeep/-/lodash.clonedeep-4.5.0.tgz#e23f3f9c4f8fbdde872529c1071857a086e5ccef"

Expand Down

0 comments on commit b96b1d9

Please sign in to comment.