-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run yarn create rwjblue-release-it-setup #86
Conversation
"release-it": "^14.2.1", | ||
"release-it-lerna-changelog": "^3.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't used these and was surprised the amount of lines added to yarn.lock
. To confirm, is the number of installed packages (resulting in about 3,000 changed LOC) expected?
Are there alternative release processes that we could consider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was also very surprised. I think it's because the other dependencies are so outdated. I can reroll yarn.lock
after the update in #87
I choose release-it
because it's the recommanded way according to adopted-ember-addons
guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Yeah, following the recommended guidelines sounds good to me.
@buschtoens and I like to use yarn-deduplicate
to maintain the lockfile and avoid installing multiple versions of a package. In #87, can you run these commands to see what happens?
# Check which packages could be de-duplicated
yarn-deduplicate --list
# De-duplicate packages
yarn-deduplicate && yarn
# Commit the lockfile (if there's a change)
Installation for yarn-deduplicate
: https://www.npmjs.com/package/yarn-deduplicate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.
@@ -0,0 +1 @@ | |||
# Changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good start. I find it nice to see an up-to-date changelog in an open-source package.
@ijlee2 as mentioned in the comment above |
To make the release process easier I run
yarn create rwjblue-release-it-setup
and fixed therepository.url
in package.json.