Skip to content

Make the heroku deployment work #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 19, 2021
Merged

Make the heroku deployment work #116

merged 4 commits into from
Mar 19, 2021

Conversation

mansona
Copy link
Member

@mansona mansona commented Mar 18, 2021

It looks like the heroku build is failing because it can't find a specific node version 🤔 the docs say that we should specify the right version using engines so I'm trying that out https://devcenter.heroku.com/articles/nodejs-support#specifying-a-node-js-version

Edit: It turns out there were more issues with this than I originally thought 🙈 here is a summary of the changes in this MR:

  • updating the engines in the package.json so the right node version is used
  • updating the heroku stack from cedar-14 (which is EOL) to heroku-20
  • Removing ACME_KEY_X and ACME_TOKEN_X from required env variables (I originally removed them but I don't know wha they are so I don't know if we should remove them 🤔 )
  • Swapped from the official emberjs buildpack because it's broken 🙈 see emberjs.tgz appears to be stale heroku/heroku-buildpack-emberjs#61 for more information

@mansona mansona temporarily deployed to fastboot-web-specify-no-tizlkm March 18, 2021 14:31 Inactive
@locks locks temporarily deployed to fastboot-web-specify-no-cdv78s March 18, 2021 14:31 Inactive
@locks locks temporarily deployed to fastboot-web-specify-no-nyxyaa March 18, 2021 14:36 Inactive
@mansona mansona force-pushed the specify-node-version branch from b1251c2 to aa88a90 Compare March 18, 2021 14:48
@mansona mansona temporarily deployed to fastboot-web-specify-no-nyxyaa March 18, 2021 14:48 Inactive
@kiwiupover
Copy link
Member

@mansona Thanks heaps Chris

@mansona mansona changed the title Update Node Engine Make the heroku deployment work Mar 18, 2021
@rwjblue rwjblue merged commit 92bb813 into master Mar 19, 2021
@rwjblue rwjblue deleted the specify-node-version branch March 19, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants