Skip to content

Adds an onFailure callback to delegate error handling to the app #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds an onFailure callback to delegate error handling to the app #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,15 @@ function fastbootExpressMiddleware(distPath, options) {
if (error.name === "UnrecognizedURLError") {
next();
} else {
log(500, "Unknown Error: " + error.stack);
if (error.stack) {
res.status(500).send(error.stack);
if (typeof opts.onFailure === 'function') {
opts.onFailure(error, req, res, next);
} else {
res.sendStatus(500);
log(500, "Unknown Error: " + error.stack);
if (error.stack) {
res.status(500).send(error.stack);
} else {
res.sendStatus(500);
}
}
}
}
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"description": "An Express middleware for rendering Ember apps with FastBoot",
"main": "index.js",
"scripts": {
"test": "mocha"
"test": "./node_modules/mocha/bin/mocha",
"test:watch": "./node_modules/mocha/bin/mocha -w"
},
"repository": {
"type": "git",
Expand Down
359 changes: 359 additions & 0 deletions test/fixtures/error-case/assets/fastboot-test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading