Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gcc 4.8 in travis-ci #153

Closed
wants to merge 1 commit into from

Conversation

mike-north
Copy link

Currently, setting up ember-cli-fastboot with a new app will cause failures in travis-ci. This is because of a known issue, where a different C++ compiler is necessary to build native code in nan (a dependency of contextify). Potentially this problem arises with any kind of native code used w/ node-gyp in iojs3 or node4.

> [email protected] install /home/travis/build/mike-north/peepchat-ui/node_modules/ember-cli-fastboot/node_modules/contextify
> node-gyp rebuild
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
make: Entering directory `/home/travis/build/mike-north/peepchat-ui/node_modules/ember-cli-fastboot/node_modules/contextify/build'
  CXX(target) Release/obj.target/contextify/src/contextify.o
In file included from ../src/contextify.cc:3:0:
../node_modules/nan/nan.h:41:3: error: #error This version of node/NAN/v8 requires a C++11 compiler
In file included from /home/travis/.node-gyp/4.4.2/include/node/node.h:42:0,
                 from ../src/contextify.cc:1:

This new installation blueprint sets up travis-ci to use the appropriate compiler to compile native code

@stefanpenner
Copy link
Contributor

I think this has been incorporated in the last PR merged

@tomdale c/d

@tomdale
Copy link
Contributor

tomdale commented Apr 5, 2016

@stefanpenner If I'm reading this correctly, I think the PR is to add the correct Travis settings to add to apps when the FastBoot addon is installed.

@stefanpenner
Copy link
Contributor

aaaa

@tomdale
Copy link
Contributor

tomdale commented Apr 6, 2016

@mike-north Won't this screw up people who already have .jshintrc and .travis.yml files?

@mike-north
Copy link
Author

@tomdale it will give users the option to accept this addon's proposed changes to .travis.yml, same as any other installation blueprint. imo this is better than a more complicated programmatic modification of the travis config file, because we'd then lose the ability to show developers what this addon wants to change.

The .jshintrc shouldn't be an issue, since that's outside of the blueprints.

@mike-north
Copy link
Author

This is moot now, since the contextify dependency has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants