Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOMHelper issue #28

Closed
furley opened this issue May 6, 2015 · 7 comments
Closed

DOMHelper issue #28

furley opened this issue May 6, 2015 · 7 comments

Comments

@furley
Copy link

furley commented May 6, 2015

Not quite sure what this means.

$ DEBUG=ember-cli-fastboot:* ember fastboot
version: 0.2.3
Built project successfully. Stored in "dist".
  ember-cli-fastboot:ember-app app created; app=dist/assets/empart.js; vendor=dist/assets/vendor.js +0ms
  ember-cli-fastboot:ember-app vendor file evaluated +165ms
DEBUG: -------------------------------
DEBUG: Ember      : 1.13.0-beta.1+canary.d10d66e8
DEBUG: Ember Data : 1.0.0-beta.17+canary.51bac6a48b
DEBUG: -------------------------------
  ember-cli-fastboot:ember-app app file evaluated +13ms
Ember FastBoot running at http://:::3000

undefined:124
        var domHelper = new Ember.View.DOMHelper(doc);
                        ^
TypeError: undefined is not a function
    at Object.initialize (<anonymous>:124:25)
    at <anonymous>:14744:23
    at <anonymous>:14767:9
    at visit (<anonymous>:12712:7)
    at DAG.topsort (<anonymous>:12824:11)
    at Namespace.default.extend._runInitializer (<anonymous>:14766:13)
    at Namespace.default.extend.runInitializers (<anonymous>:14740:12)
    at Namespace.default.extend.boot (<anonymous>:14656:12)
    at Namespace.default.extend.domReady (<anonymous>:14640:12)
    at Queue.invoke (<anonymous>:11430:18)
@jimjamdev
Copy link

Same issue here

@rwjblue
Copy link
Member

rwjblue commented May 11, 2015

Canary has a few regressions related to Fastboot support (since Glimmer PR landing).

I created emberjs/ember.js#11115 upstream to track the issues in Ember itself.

@furley
Copy link
Author

furley commented May 11, 2015

Excellent. Thank you @rwjblue

@code0100fun
Copy link
Contributor

Would this just be changed to var domHelper = new Ember.HTMLBars.DOMHelper(doc);?

@rwjblue
Copy link
Member

rwjblue commented May 12, 2015

@code0100fun - Yes, that is the first step, but there is more breakage after fixing that.

@rwjblue
Copy link
Member

rwjblue commented May 12, 2015

@code0100fun - These tests will likely point the way to fixing in Ember itself (they are skipped for now, to land Glimmer so we can iterate with real user testing).

@rwjblue
Copy link
Member

rwjblue commented May 24, 2015

Fixed by #35. All credit goes to @code0100fun for tracking down the root issues, thank you!!

@rwjblue rwjblue closed this as completed May 24, 2015
arjansingh pushed a commit to arjansingh/ember-cli-fastboot that referenced this issue Oct 29, 2016
Add static asset serving + CLI test infrastructure
xg-wang pushed a commit to xg-wang/ember-cli-fastboot that referenced this issue Nov 16, 2020
xg-wang pushed a commit to xg-wang/ember-cli-fastboot that referenced this issue Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants