Fix compatibility with Ember 3.24+ #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to Ember 3.24 within a `setupRenderingTest` a link-to-external we short curcuit well before attempting to invoke `_getExternalRoute` (because no router was present, so it did nothing). As of Ember 3.24+ the router is setup and available on demand (including in these types of rendering tests). This moves the initial definition of `engineOwner._externalRoutes` to `init` of the engine instance instance (so that we know it is always initialized) and updates a couple of tests to ensure that a proper external route mapping is setup.
Also includes a work around for 3.24.0 (which should be fixed in Ember 3.24.1 once released).
rwjblue
force-pushed
the
fix-ember-3-24
branch
from
6844f6c
to
25856b6
Compare
As of Ember 3.26+, `LinkTo` will lazily boot the router when rendered. This means that we now will receive assertions if we attempt to `<LinkTo @route="foo" />` where `foo` route does not exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
<LinkTo>should link within the engine when used inside one emberjs/ember.js#19223Closes #740