Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various JSDoc issues #98

Merged
merged 1 commit into from
May 7, 2020
Merged

Conversation

loganrosen
Copy link
Contributor

I threw this addon into VSCode and fixed various JSDoc issues that popped up (e.g. using Any instead of *). One file (bundle-load.js) didn't have the right parameters documented.

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thank you!

@rwjblue rwjblue merged commit 98d2d77 into ember-engines:master May 7, 2020
@loganrosen loganrosen deleted the fix-jsdoc branch May 15, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants