Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds option to prevent loader.js modifying export #129

Merged

Conversation

mlunoe
Copy link

@mlunoe mlunoe commented Jul 26, 2017

This PR creates a workaround for #114

Adding an option to enable(default)/disable makeDefaultExport, which mutates the module exports will allow for us to avoid this issue immediately and for maintainers to start a deprecation cycle when ready.

Related to PR: #128

Michael Lunoe added 4 commits July 26, 2017 10:15
…port

This property allows for an immediate option to remove the functionality
that mutates the module exports (ember-cli#114)
and allows for a deprecation cycle when maintainers are ready to do so

Workaround for ember-cli#114
@mlunoe mlunoe force-pushed the mlunoe/optional-default-export-creation branch from 3c52f6b to 005756f Compare July 26, 2017 22:18
@stefanpenner stefanpenner merged commit 7b5dc9a into ember-cli:master Jul 26, 2017
@stefanpenner
Copy link
Contributor

released as v4.6.0 🎉

@mlunoe mlunoe deleted the mlunoe/optional-default-export-creation branch July 26, 2017 22:36
@mlunoe
Copy link
Author

mlunoe commented Jul 26, 2017

Wow! Thanks for the fast turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants