Skip to content

Conversation

@nlfurniss
Copy link
Contributor

@nlfurniss nlfurniss commented Mar 5, 2020

A rule for not creating mixins (e.g. Mixin.create({})) already exists, but no rule disallows their actual usage (fixes #270) .

I opted to rely on the Ember directory convention of some/code/mixins/my-mixin for the rule as it's easier than looking at the arguments to extend but I'm open to other ways 🙂

@bmish bmish changed the title Add rule to disallow mixins Add new rule no-mixins Mar 5, 2020
@nlfurniss nlfurniss requested a review from bmish March 5, 2020 07:53
Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmish bmish requested a review from rwjblue March 5, 2020 16:55
@bmish bmish merged commit 66aae10 into ember-cli:master Mar 7, 2020
@nlfurniss nlfurniss deleted the no-mixins-rule branch March 7, 2020 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rule for no-mixins?

2 participants