include recommended ts-eslint rules for gts #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or ts/gts but they only to that for known extensions, therefore we need to reapply them in our recommended config see issue typescript-eslint/typescript-eslint#8607
patricklx
force-pushed
the
add-ts-recommended-to-gts
branch
from
6600335
to
5aee9fc
Compare
bmish
reviewed
Mar 12, 2024
|
i changed it to just copy the rules instead |
NullVoxPopuli
approved these changes
Mar 27, 2024
| @@ -1,4 +1,29 @@ | |||
| const base = require('./base'); | |||
| const gtsRules = require('../recommended-rules-gts'); | |||
|
|
|||
| module.exports = [...base, { rules: gtsRules }]; | |||
| // see https://github.com/typescript-eslint/typescript-eslint/issues/8607 | |||
| // https://github.com/typescript-eslint/typescript-eslint/blob/v7.4.0/packages/eslint-plugin/src/configs/eslint-recommended-raw.ts | |||
There was a problem hiding this comment.
why don't we use this config? because we can't force v7?
and we don't want a peer requirement? (I think that's what we ended up deciding on elsewhere, yeah?)
There was a problem hiding this comment.
That cannot be used directly. It's a utility function. Eslint needs an object as default export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typescript recommended rules turn off eslint rules that do not work for ts/gts
but they only to that for known extensions, therefore we need to reapply them in our recommended config
see issue typescript-eslint/typescript-eslint#8607
fixes #2106