Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEMO] "Fixes" failing CI tests post ember-template-imports upgrade #1684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[DEMO] "Fixes" failing CI tests post ember-template-imports upgrade #1684

wants to merge 1 commit into from

Conversation

nlfurniss
Copy link
Contributor

@nlfurniss nlfurniss commented Nov 29, 2022 •
edited
Loading

Discussed in #1667. Not meant to be merged

@NullVoxPopuli

@bmish
Copy link
Member

bmish commented Nov 29, 2022

Can you explain? Why are quotes needed?

@bmish bmish added the internal label Nov 29, 2022
NullVoxPopuli
NullVoxPopuli reviewed Nov 29, 2022
View reviewed changes
tests/lib/rules-preprocessor/gjs-gts-processor-test.js
@@ -82,7 +82,7 @@ const valid = [
{
filename: 'my-component.gjs',
code: `
const Foo = <template>hi</template>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi is valid text tho

@nlfurniss
Copy link
Contributor Author

I dont know yet, just pseudo-figured out the issue and wanted to put this up for reference

@bmish
Copy link
Member

bmish commented Nov 29, 2022 •
edited
Loading

Appreciate you looking into this! For the record, I would prefer we skip the test with a TODO comment linking to the issue to fix it, instead of just changing the test to pass. Would like to make sure we don't lose track of these failing test cases...(note: we can still add the new passing test case too).

@nlfurniss
Copy link
Contributor Author

Appreciate you looking into this! For the record, I would prefer we skip the test with a TODO comment linking to the issue to fix it, instead of just changing the test to pass. Would like to make sure we don't lose track of these failing test cases...(note: we can still add the new passing test case too).

Yeah this PR wasn't meant to be merged. Will modify it accordingly

@nlfurniss nlfurniss changed the title Fixes failing CI tests post ember-template-imports upgrade [DEMO] "Fixes" failing CI tests post ember-template-imports upgrade Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NullVoxPopuli NullVoxPopuli NullVoxPopuli left review comments

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nlfurniss @bmish @NullVoxPopuli