Propose new rule: no-unsafe-this-access #1421
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #424
the intent is to protect people from accidentally having issues in testing (or very fast humans).
For framework objects, this is auto-fixable -- for non-framework objects, I think we can suggest / warn as determining if a non-framework class is also destroyable is a bit difficult and needs some really good static analysis (which we don't yet have?)