Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty-but-decorated classes in no-empty-glimmer-component-classes rule #1374

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Allow empty-but-decorated classes in no-empty-glimmer-component-classes rule #1374

merged 1 commit into from
Nov 23, 2021

Conversation

adrigzr
Copy link
Contributor

@adrigzr adrigzr commented Nov 22, 2021

Fixes #1373

@bmish bmish changed the title Allow empty glimmer component class with decorator Allow empty-but-decorated classes in no-empty-glimmer-component-classes rule Nov 23, 2021
@bmish bmish added the Bug label Nov 23, 2021
bmish
bmish approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmish bmish merged commit 7128c23 into ember-cli:master Nov 23, 2021
@adrigzr adrigzr deleted the bugfix-empty-glimmer-component-class-with-decorator branch November 23, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmish bmish bmish approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow empty glimmer component class with decorator
2 participants
@adrigzr @bmish