Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existing rules to handle native classes #560

Closed
bmish opened this issue Oct 30, 2019 · 4 comments
Closed

Update existing rules to handle native classes #560

bmish opened this issue Oct 30, 2019 · 4 comments

Comments

@bmish
Copy link
Member

bmish commented Oct 30, 2019

For example, no-new-mixins presumably should apply to both classic/native classes.

This would be good preparation for Ember Octane.

Originally posted by @bmish in #558 (comment)

Related to #566.

@laurmurclar
Copy link
Contributor

The order-in-* rules were already called out: #417

I can start fixing those today

@bmish
Copy link
Member Author

bmish commented Nov 5, 2019

@laurmurclar that would be great, thanks! I was looking at the code for those rules and it looks like it should be quick to update them. If we can get that change in today then I'll include it in a new release today.

@laurmurclar
Copy link
Contributor

@bmish Afraid it wont be today! But feel free to work away at them if you have time

@bmish
Copy link
Member Author

bmish commented Jun 8, 2020

I'm going to close this. At this point, most rules have been updated with support for native JavaScript classes and decorators, including the most important ones. The few remaining rules that haven't been updated note "Missing native JavaScript class support" in their rule docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants