-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order-in-* rules do not work in native class syntax #417
Comments
@lstrzebinczyk This is a known issue in that I chatted about it with a few folks on Discord a month or so ago. I assume a PR fixing this would be welcome :) |
I'll start putting a PR together for these |
@laurmurclar Id love to see progress on this. I messed around with AST explorer a few months ago but had a tough time understanding how the transforms work. Good luck! |
@Alonski sweet. I could give you a hand with that some time if you're interested! Can be hard to get started alone |
I don't have time to finish this off right now, but I made a start by updating some util functions that this work will rely on (see #574). If anyone else has time, feel free to pick it up |
It would seem that, as in issue, if code is written using modern native classess + decorators, the order-in-* rules do not pick it up. Example would be, from my codebase:
If I were to put
@service
lower in the file, no error is raised. I am also using typescript, but that doesn't seem to matter for other rules.What is the situation here, is this a known issue? And first of all, do I understand correctly that the expected situation would be for this rule to be applied to native class based ember entities?
The text was updated successfully, but these errors were encountered: