Merge pull request #930 from bmish/no-restricted-resolver-tests-fix-s…

…pread Fix spread syntax crash in `no-restricted-resolver-tests` rule
ember-cli · Sep 7, 2020 · b51433c · b51433c
2 parents b77e14f + 3f080b7
commit b51433c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/lib/rules/no-restricted-resolver-tests.js b/lib/rules/no-restricted-resolver-tests.js
@@ -32,19 +32,26 @@ function hasOnlyStringArgument(node) {
 
 function hasUnitTrue(node) {
   return node.properties.some(
-    (property) => property.key.name === 'unit' && property.value.value === true
+    (property) =>
+      types.isProperty(property) && property.key.name === 'unit' && property.value.value === true
   );
 }
 
 function hasNeeds(node) {
   return node.properties.some(
-    (property) => property.key.name === 'needs' && property.value.type === 'ArrayExpression'
+    (property) =>
+      types.isProperty(property) &&
+      property.key.name === 'needs' &&
+      property.value.type === 'ArrayExpression'
   );
 }
 
 function hasIntegrationTrue(node) {
   return node.properties.some(
-    (property) => property.key.name === 'integration' && property.value.value === true
+    (property) =>
+      types.isProperty(property) &&
+      property.key.name === 'integration' &&
+      property.value.value === true
   );
 }
 

diff --git a/tests/lib/rules/no-restricted-resolver-tests.js b/tests/lib/rules/no-restricted-resolver-tests.js
@@ -12,13 +12,15 @@ const { ERROR_MESSAGES } = rule;
 //------------------------------------------------------------------------------
 
 const ruleTester = new RuleTester({
+  parser: require.resolve('babel-eslint'),
   parserOptions: { ecmaVersion: 6, sourceType: 'module' },
 });
 ruleTester.run('no-restricted-resolver-tests', rule, {
   valid: [
     `
     import { moduleFor } from 'ember-qunit';
     moduleFor('service:session', {
+      ...foo,
       integration: true
     });
     `,