-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dependencies to their latest version #391
Conversation
…-regenerator (patches #388, forgot to uninstall after running ember-cli-update in test-app)
… keep the root package.json simple
"release-it": "^15.5.1", | ||
"release-it-lerna-changelog": "^5.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested the command yarn release-it
. It's possible that I missed something when updating release-it
and release-it-lerna-changelog
.
"rollup": "^2.57.0", | ||
"release-it": "^15.5.1", | ||
"release-it-lerna-changelog": "^5.0.0", | ||
"rollup": "^3.7.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested @embroider/*
and rollup
by running yarn start
at the root directory. I was able to visit http://localhost:4200 and see the demo app render the <WelcomePage>
component.
@@ -61,10 +61,8 @@ | |||
"ember-cli-inject-live-reload": "^2.1.0", | |||
"ember-cli-sri": "^2.1.1", | |||
"ember-cli-terser": "^4.0.2", | |||
"ember-export-application-global": "^2.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to remove this line in #388. (yarn sync-dev-deps
is fallible.)
"ember-fetch": "^8.1.2", | ||
"ember-load-initializers": "^2.1.2", | ||
"ember-maybe-import-regenerator": "^0.1.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to remove this line in #388. (yarn sync-dev-deps
is fallible.)
Description
In this pull request, I updated dependencies that had released a major version. As I'm not too familiar with the packages, it's possible that I didn't address the breaking changes correctly.
For an up-to-date
rollup
configuration (e.g. need to change the file extension to.mjs
), I referred to an addon generated byembroider-build/addon-blueprint
.References
See release notes for breaking changes:
@embroider
@rollup/plugin-babel
release-it
release-it-lerna-changelog
rollup