Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies to their latest version #391

Merged
merged 7 commits into from
Dec 17, 2022
Merged

Updated dependencies to their latest version #391

merged 7 commits into from
Dec 17, 2022

Conversation

ijlee2
Copy link
Contributor

@ijlee2 ijlee2 commented Dec 17, 2022

Description

In this pull request, I updated dependencies that had released a major version. As I'm not too familiar with the packages, it's possible that I didn't address the breaking changes correctly.

Package                        Current Wanted  Latest Package Type    URL
@embroider/addon-dev           1.8.3   1.8.3   3.0.0  devDependencies https://github.com/embroider-build/embroider#readme
@embroider/test-setup          1.8.3   1.8.3   2.0.2  devDependencies https://github.com/embroider-build/embroider#readme
@rollup/plugin-babel           5.3.1   5.3.1   6.0.3  devDependencies https://github.com/rollup/plugins/tree/master/packages/babel#readme
release-it                     14.14.3 14.14.3 15.5.1 devDependencies https://github.com/release-it/release-it#readme
release-it-lerna-changelog     3.1.0   3.1.0   5.0.0  devDependencies https://github.com/rwjblue/release-it-lerna-changelog#readme
rollup                         2.79.1  2.79.1  3.7.5  devDependencies https://rollupjs.org/

For an up-to-date rollup configuration (e.g. need to change the file extension to .mjs), I referred to an addon generated by embroider-build/addon-blueprint.

References

See release notes for breaking changes:

@ijlee2 ijlee2 marked this pull request as ready for review December 17, 2022 14:16
Comment on lines +84 to +85
"release-it": "^15.5.1",
"release-it-lerna-changelog": "^5.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the command yarn release-it. It's possible that I missed something when updating release-it and release-it-lerna-changelog.

"rollup": "^2.57.0",
"release-it": "^15.5.1",
"release-it-lerna-changelog": "^5.0.0",
"rollup": "^3.7.5",
Copy link
Contributor Author

@ijlee2 ijlee2 Dec 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested @embroider/* and rollup by running yarn start at the root directory. I was able to visit http://localhost:4200 and see the demo app render the <WelcomePage> component.

@@ -61,10 +61,8 @@
"ember-cli-inject-live-reload": "^2.1.0",
"ember-cli-sri": "^2.1.1",
"ember-cli-terser": "^4.0.2",
"ember-export-application-global": "^2.0.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to remove this line in #388. (yarn sync-dev-deps is fallible.)

"ember-fetch": "^8.1.2",
"ember-load-initializers": "^2.1.2",
"ember-maybe-import-regenerator": "^0.1.6",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to remove this line in #388. (yarn sync-dev-deps is fallible.)

@ijlee2 ijlee2 merged commit 708a889 into ember-cli:main Dec 17, 2022
@ijlee2 ijlee2 deleted the PR-04 branch December 17, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant