Update test format, run ember-cli-update #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove node-tests, update lint
|
Travis still doesn't seem to be reporting here, but the build appears to be running here https://travis-ci.org/github/ember-cli/ember-welcome-page/builds/697317347 |
ijlee2
reviewed
Jun 11, 2020
ijlee2
reviewed
Jun 11, 2020
Co-authored-by: Isaac Lee <[email protected]>
ijlee2
approved these changes
Jun 11, 2020
MelSumner
requested changes
Jun 11, 2020
|
@MelSumner I was thinking it's best to have 3 separate commits. This one fixes the build and modernizes, yours will add the a11y stuff, and then I will follow up with a third PR doing the updates for the production stuff. If that's okay with you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the test format to the new testing style, runs ember-cli-update, removes jQuery, enables Octane, etc.
I also removed
node-testsas it did not seem to be used. Please correct me if I am wrong there.