Upgrade to Glimmer 2 #501
Merged
Upgrade to Glimmer 2 #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try again to fix phantomjs failures Try again to fix phantomjs failures Try again to fix phantomjs crashes in travis Try again to fix phantomjs crashes in travis
Try using Chrome instead Try using Chrome instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #500 but isn't working. Getting the error:
''Error while processing route: gist.edit.revision' 'Assertion Failed: You\'re not allowed to have more than one controller property map to the same query param key, but both
gist:numColumnsandgist:numColumnsmap tonumColumns. You can fix this by mapping one of the controller properties to a different query param key via theasconfig option, e.g.numColumns: { as: \\\'other-numColumns\\\' }'\n'This appears to be issue emberjs/ember.js#14560
Update: Got it working but PhantomJs is crashing on Travis