NPM scenario support

[mike-north]

This may be quick and dirty at first, but I have a need to test 1.13.x >= ember >= 1.7.x, so I'm going to take a stab at it. Let's also let this be a place to start a discussion for "the proper approach" to adding NPM support.

Commands

No changes should be needed to the ember try* commands, although their internals will have to be enhanced

Configuration - config/ember-try.js

////////////////////////
//// EXISTING
////////////////////////

{
  name: 'ember-1.10',
  dependencies: {
    'ember': '~1.10.0'
  },
  resolutions: {
    'ember': '~1.10.0'
  }
}

////////////////////////
//// SUPPORTED
////////////////////////

{
  name: 'ember-1.10',
  dependencies: {
    'ember': '~1.10.0'
  },
  resolutions: {
    'ember': '~1.10.0'
  },
  npm: {
    dependencies: {
      'ember': '~1.10.0'
    },
    resolutions: {
      'ember': '~1.10.0'
    }
  }
}

////////////////////////
//// ENCOURAGED
////////////////////////

{
  name: 'ember-1.10',
  bower: {
    dependencies: {
      'ember': '~1.10.0'
    },
    resolutions: {
      'ember': '~1.10.0'
    },
  }
  npm: {
    dependencies: {
      'ember': '~1.10.0'
    },
    resolutions: {
      'ember': '~1.10.0'
    }
  }
}

Thoughts

• The cost of a "npm install" is, for most people, way higher than the cost of a bower install.
  • It would be fantastic if adding this feature didn't increase the time it takes to run through a set of scenarios by much.
  • We could probably move the existing node_modules so that it's easy to put back when we want to ember try:reset
  • We probably do not want to blow the whole node_modules folder away if we don't have to
  • There's the issue of ember-try its self being in node_modules.
• For the use case of dealing w/ various versions of handlebars, some packages will need to be removed from package.json. The current way that bower.json is handled supports only adding.
• I see no problem with the approach of backing up the bower.json file to bower.json.ember-try. This should apply equally well to package.json
• Basic implementation
• Save time by explicitly altering single packages (instead of a broad "npm install")
• Test coverage for a variety of npm scenarios
• Documentation

[mike-north]

I'm still just poking around with the code for now, so it's probably not worth reviewing yet :)

[mike-north]

This now works for a bunch of cases that I have tested. Just cleaning stuff up at this point, and potentially logging some more information out so people can feel confident that their scenario is being set up as they expect.

[mike-north]

NOTE TO SELF: Needs a nice comment

[mike-north]

Ok this works now, and is ready for review @kategengler @rwjblue

[kategengler]

I can't comment on the exact line because github won't let me, but above there's a backupBowerFile call that might need to be accompanied by a backupNpmFile?

[mike-north]

Found a few cases where there are still problems, and I should be able to address them within the next day or two

[ghost]

Hey @mike-north, whats the status on this?

[mike-north]

Got sidetracked on something else. Not sure when I'll be able to pick this back up, but it needs some more love before merge

[ming-codes]

👍 This would be very helpful.

Ember 1.13 loads helper automatically, but 1.12 needs another add-on to do this.

[ghost]

This would be a great feature to have merged, is there any way I can help to get this one merged?

[mike-north]

it proved to be quite a bit more complicated than I initially thought (I
know, surprise!). While my initial solution works in some cases, it's quite
easy to poke holes and make it fall on its face. It's unclear when I'll
have time to give it some love

On Mon, Dec 21, 2015 at 12:54 AM Marten [email protected] wrote:

This would be a great feature to have merged, is there any way I can help
to get this one merged?

—
Reply to this email directly or view it on GitHub
#26 (comment).

[kategengler]

I've been working on npm support, but with a very different approach.

[kategengler]

Closing in favor of #45