fix: update docs around pluralizedTypes and type the field #951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #902 resolver was converted to native class which has a different semantics around object initialization.
Per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Public_class_fields
If you define
pluralizedTypes
in the app, previously the following lines run ininit()
hook,which runs after properties assigned to the class instance in the child class.now, above lines run before properties assigned to the class instance in the child class. Which means,
pluralizedTypes
defined in the child class overridesconfig
mapping.Because of this semantic change, any addon doing
application.resolveRegistration('config:environment')
would receiveundefined
instead of reference to the app config.Docs should anyway teach updated syntax of
pluralizedTypes
definition.We may argue if addons doing the right thing here or not (I would think latter is true as addons should migrate to
@embroider/macros
and utilizegetOwnConfig
,getConfig
, andgetGlobalConfig
), but that's out of scope of this issue.EDIT: no tests added here as there is actually nothing wrong with the addon code, it's just an app code needs to be updated.