Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: embed @ember/string utils #933

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Conversation

lifeart
Copy link
Contributor

@lifeart lifeart commented Jul 13, 2023

Resolves #932

@NullVoxPopuli
Copy link
Contributor

Can you also remove the peer? https://github.com/ember-cli/ember-resolver/blob/main/addon/package.json#L30 thanks!!! <3

@@ -1773,17 +1772,6 @@
"node": ">=8"
}
},
"node_modules/@ember/string": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline used @ember/string methods directly
4 participants