Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid dot notation for property default #9

Merged
merged 1 commit into from
Nov 18, 2013
Merged

Avoid dot notation for property default #9

merged 1 commit into from
Nov 18, 2013

Conversation

zeppelin
Copy link
Contributor

IE particularly hates it.

@rwjblue
Copy link
Member

rwjblue commented Nov 18, 2013

I hate storing the dist output in the repo, but anything else is a giant PITA with Bower. I'd like to keep the updating of /dist to be done after PR's are merged (to hopefully keep a more sane commit log).

@zeppelin - Could you update this PR to only make the changes to the source files? Once finished, I'll merge and update the /dist output.

IE particularly hates it.
@zeppelin
Copy link
Contributor Author

@rjackson done! /cc @stefanpenner

rwjblue added a commit that referenced this pull request Nov 18, 2013
Avoid dot notation for property `default`
@rwjblue rwjblue merged commit 027a1d5 into ember-cli:master Nov 18, 2013
rwjblue added a commit that referenced this pull request Nov 18, 2013
@rwjblue
Copy link
Member

rwjblue commented Nov 18, 2013

/dist updated in c4b4afa.

@zeppelin zeppelin deleted the ie-keyword-default branch November 18, 2013 14:16
kratiahuja pushed a commit to kratiahuja/ember-resolver that referenced this pull request Aug 5, 2016
Revert "Merge pull request ember-cli#4 from abuiles/define-amd"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants