Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podModulePrefix deprecation warning. #88

Merged
merged 4 commits into from
Mar 15, 2015
Merged

Conversation

trabus
Copy link
Contributor

@trabus trabus commented Mar 15, 2015

This PR adds a deprecation warning when 'podModulePrefix' is defined on the resolver.

@rwjblue
Copy link
Member

rwjblue commented Mar 15, 2015

Added a few commits fixing up the error that you were having. This is good to go now.

@rwjblue rwjblue changed the title [WIP] Add podModulePrefix deprecation warning Add podModulePrefix deprecation warning. Mar 15, 2015
rwjblue added a commit that referenced this pull request Mar 15, 2015
Add podModulePrefix deprecation warning.
@rwjblue rwjblue merged commit 097d0ad into master Mar 15, 2015
@rwjblue rwjblue deleted the deprecate-podmoduleprefix branch March 15, 2015 21:34
@rwjblue
Copy link
Member

rwjblue commented Mar 15, 2015

Tagged as v0.1.13.

@rwjblue
Copy link
Member

rwjblue commented Mar 15, 2015

A few changes made in #89 (had to make the deprecation lazy because of silly ember-cli blueprint).

@trabus
Copy link
Contributor Author

trabus commented Mar 16, 2015

@rwjblue Thanks for tracking that down, and fixing it. I wasn't getting very far with it!

kratiahuja pushed a commit to kratiahuja/ember-resolver that referenced this pull request Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants