Stamp Resolver class to indicate it is a modulesBasedResolver. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should it also be on the instance? Or is constructor sufficient Lgtm when green |
|
Good idea to add to instance (will do), builds are failing because of requiring super-mega old Ruby based ember-dev (changed to ember-cli addon). Should have it fixed shortly, but we definitely need to rework the build system here to be a tad bit saner. |
Due to emberjs/ember.js@f9ecb12 it not possible to call `this.deferReadiness()` in an Application's `init` (because this._readinesDeferrals are not greater than 1 which causes an assertion in the deferReadiness function call).
|
Mucho annoyance with the tests, but all is green now. Stamping both the instance and the class (Ember itself uses the class). |
rwjblue
added a commit
that referenced
this pull request
Dec 21, 2014
Stamp Resolver class to indicate it is a modulesBasedResolver.
|
And released as 0.1.11. |
kratiahuja
pushed a commit
to kratiahuja/ember-resolver
that referenced
this pull request
Aug 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream chagnes in Ember require this resolver to be stamped: emberjs/ember.js#9994