switch back to inheriting from Ember.DefaultResolver #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(cc @teddyzeenny) |
| Ember.Resolver = Ember.DefaultResolver; | ||
| } | ||
| if (typeof requirejs.entries === 'undefined') { | ||
| requirejs.entries = requirejs._eak_seen; |
There was a problem hiding this comment.
It seems that the _eak_seen check is still needed for sure.
|
Just re-added the |
|
@teddyzeenny ok... I just changed the gem dependency back to beta4 since it was already decided. Is definitely confusing to clone a repo and have non-existent dependencies though. |
|
@ghempton confusing agreed, but it will be sorted out by monday. |
teddyzeenny
added a commit
that referenced
this pull request
Mar 6, 2014
switch back to inheriting from Ember.DefaultResolver
|
👍 @ghempton. Sorry about the gem version confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although I think it would be great to have a pristine module-only resolver, we are still tied to real world use cases that Ember.DefaultResolver solves– namely,
Ember.TEMPLATES. Libraries such as ember-easyForm and the emblem.js compiler in EAK still use Ember.TEMPLATES.