Fancier logging! #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd the module identifier that is requested via requirejs.
|
I like it! Can you fix the build failure (JSHint issue)? |
|
nice |
| @@ -113,13 +113,13 @@ define("resolver", | |||
| } | |||
|
|
|||
| if (Ember.ENV.LOG_MODULE_RESOLVER) { | |||
| Ember.Logger.info('hit', moduleName); | |||
| Ember.Logger.info('[*]', parsedName.fullName, Array(40 - parsedName.fullName.length).join('.'), moduleName); | |||
There was a problem hiding this comment.
I like that.
Given Ember code standards, can we use ✓ (the unicode character) in the code or should we use String.fromCharCode(0x2713) ?
|
Possibly out of scope, but I'd love to start adding tests for future changes. In this case we could just test that hit and miss return the expected value. |
|
Looks great to me :) |
|
thoughts on my unicode checkmark proposal? |
|
I like the idea of using the checkmark. |
|
✓ should be fine, unless their exists an issue i am aware of. |
|
👍 |
kratiahuja
pushed a commit
to kratiahuja/ember-resolver
that referenced
this pull request
Aug 5, 2016
Add license and barebones README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display both fullname as passed into the resolver and the module identifier that is requested via requirejs.
I think this makes it much easier to understand what the resolver is doing.
What do you think?