Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies #294

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 19, 2018

We don't publish the dummy app, so we don't need all of these addons.

@Turbo87 Turbo87 requested a review from a team December 19, 2018 17:48
@stefanpenner
Copy link
Contributor

not ok 8 Chrome 71.0 - [2 ms] - ember-resolver/resolvers/classic: can access at deprecated 'resolver' module name
    ---
        actual: >
            null
        stack: >
            Error: Could not find module `ember` imported from `resolver`
                at missingModule (http://localhost:7357/assets/vendor.js:252:11)
                at findModule (http://localhost:7357/assets/vendor.js:263:7)
                at Module.findDeps (http://localhost:7357/assets/vendor.js:173:24)
                at findModule (http://localhost:7357/assets/vendor.js:267:11)
                at requireModule (http://localhost:7357/assets/vendor.js:29:15)
                at r (http://localhost:7357/assets/vendor.js:181:14)
                at Object.<anonymous> (http://localhost:7357/assets/tests.js:197:47)
                at runTest (http://localhost:7357/assets/test-support.js:4226:30)
                at Test.run (http://localhost:7357/assets/test-support.js:4212:6)
                at http://localhost:7357/assets/test-support.js:4433:12

@Turbo87
Copy link
Member Author

Turbo87 commented Dec 19, 2018

@stefanpenner see #295

We don't publish the dummy app, so we don't need all of these addons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants