Remove falling back to DefaultResolver #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisselden
force-pushed
the
remove-default-resolver
branch
from
62f62e9
to
c77449d
Compare
knownasilya
reviewed
Jun 29, 2018
| @@ -108,17 +107,14 @@ function resolveOther(parsedName) { | |||
| } | |||
|
|
|||
| return defaultExport; | |||
| } else { | |||
| return this._super(parsedName); | |||
| } | |||
| } | |||
|
|
|||
| // Ember.DefaultResolver docs: | |||
There was a problem hiding this comment.
Probably remove these comments too?
|
The fallback behavior will need to issue a deprecation for a cycle before removal (in the next major bump of this lib). |
|
released as v5.0.1 🎉 |
|
After further discussion, I actually think this is just a straight up bugfix. The scenario where the fallback was actually used is more likely to troll folks than do what you want. Sorry for the run around @krisselden... |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No one uses
MyApp.MyClass = Ember.Object.extend()anymore, especially if they are using the ember-cli/resolver. This removes extending from DefaultResolver since falling back to it ups the cost of misses.