-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of the module unification feature flag #182
Conversation
index.js
Outdated
/* Add default feature flags here */ | ||
EMBER_RESOLVER_MODULE_UNIFICATION: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line must be changed before merge. It defaults the FF to true
when what we want is: true
only if configured or when running tests.
package.json
Outdated
"babel-plugin-debug-macros": "^0.1.1", | ||
"broccoli-babel-transpiler": "^5.6.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this dependency is not required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally ember-cli
should be version 2.13.0-beta.2
. There is code in index.js
which is run when the feature flag is enabled (which it should be for tests, but not for tests on older versions of Ember).
7ce93a2
to
4603705
Compare
index.js
Outdated
|
||
this.options.babel = { | ||
loose: true, | ||
blacklist: ['es6.modules'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is incorrect, babel 6 does not have a blacklist like this
Quite barebones and very much a WIP. The mentioned instructions should be helpful for smoke testing:
@iezer is following up to push a commit with further tests for the RequireJS ModuleRegistry.