Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of the module unification feature flag #182

Merged
merged 4 commits into from
Mar 28, 2017

Conversation

mixonic
Copy link
Member

@mixonic mixonic commented Mar 27, 2017

Quite barebones and very much a WIP. The mentioned instructions should be helpful for smoke testing:

# Install Ember-CLI canary globally:
npm install -g ember-cli/ember-cli
# Create a new app with the module unification blueprint
ember new my-app -b ember-module-unification-blueprint

@iezer is following up to push a commit with further tests for the RequireJS ModuleRegistry.

index.js Outdated
/* Add default feature flags here */
EMBER_RESOLVER_MODULE_UNIFICATION: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line must be changed before merge. It defaults the FF to true when what we want is: true only if configured or when running tests.

package.json Outdated
"babel-plugin-debug-macros": "^0.1.1",
"broccoli-babel-transpiler": "^5.6.2",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this dependency is not required.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally ember-cli should be version 2.13.0-beta.2. There is code in index.js which is run when the feature flag is enabled (which it should be for tests, but not for tests on older versions of Ember).

index.js Outdated

this.options.babel = {
loose: true,
blacklist: ['es6.modules'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is incorrect, babel 6 does not have a blacklist like this

@rwjblue rwjblue merged commit a24d4ae into ember-cli:master Mar 28, 2017
@mixonic mixonic mentioned this pull request May 30, 2017
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants