Add failing test for @content-helper lookup

[tim-evans]

Related to #101

[rwjblue]

Ok. Now fix it ;)

[rwjblue]

Looks good to me.

@stefanpenner - Thoughts?

[stefanpenner]

can someone describe concisely the use of @ here, and how it relates to the existing namespace usage? In this case is it merely referring to the current namespace?

[rwjblue]

@stefanpenner - This helper:@content-helper lookup is done by HTMLBars (I assume that it uses an @ to prevent collisions or something), so the @ here has nothing to do with the namespace concept that we have added to this resolver (which is why we are trying to detect invalid usage and falling back out of the "namespaced lookup" path).

[rwjblue]

I wrote a little more of a rambling explanation in #101 (comment) and emberjs/ember.js#11987.

[stefanpenner]

@rwjblue thanks for the links, let me read the backchat.

[stefanpenner]

• lets leave a comment here describing why this is needed
• it seems like the above split fullName.split('@'); (on line 58) is not needed if we hit this branch, this should be cleaned up

[tim-evans]

@stefanpenner Is the comment and changes I made sufficient?

[stefanpenner]

@tim-evans yup, LG.

@rwjblue you are more familiar with that part of HTMLBars, so merge & release when you are comfortable with it.

[rwjblue]

OK, I did a bit more digging into what was happening and I'd prefer to specifically blacklist helper:@content-helper for now. It is a "magic" value (that @mmun is going to try and remove in HTMLBars), and the issue should not occur on canary already (because of cleanup work done to remove support for Ember.Handlebars.makeViewHelper).

@tim-evans - Can you tweak (hopefully for the last time) to just compare fullName === 'helper:@content-helper'?

[mmun]

Can't this change be made in htmlbars instead? @content-helper is an internal that shouldn't be leaking out...

[tim-evans]

@rwjblue done.

[rwjblue]

Beautiful!

[mmun]

Ok rwjblue convinced me this is good

[tim-evans]

Could we get a release on this? ember-document-title doesn't work on 1.13.X because of this. :(

I checked on 1.13.8 and it no longer throws errors when calling {{title}}, but calls the helper, which is not right at all.

[stefanpenner]

releasing now.

[stefanpenner]

➜  ember-resolver git:(master) git tag v0.1.19
➜  ember-resolver git:(master) git push origin v0.1.19
Total 0 (delta 0), reused 0 (delta 0)
To [email protected]:ember-cli/ember-resolver

[stefanpenner]

@tim-evans let me know if that does the trick, sorry for letting this linger.

[tim-evans]

Sadly, no. I'll come up with an ember-twiddle to report this.

[stefanpenner]

@tim-evans ah so an additional bug in the resolver?

[tim-evans]

http://ember-twiddle.com/b3b796e77b72d2e6c816

[tim-evans]

I'm not sure.

[stefanpenner]

@tim-evans can you open a new issue, describing what is expected. I would love to dive in later this morning :)