Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MU resolver does not convert camelCase to kebap-case for has check #299

Closed
buschtoens opened this issue Dec 20, 2018 · 0 comments
Closed

MU resolver does not convert camelCase to kebap-case for has check #299

buschtoens opened this issue Dec 20, 2018 · 0 comments

Comments

@buschtoens
Copy link
Contributor

buschtoens commented Dec 20, 2018 •
edited
Loading

Basically a reprise of #195. Originally reported as ember-decorators/ember-decorators#337.

Service injections that rely on the property key reflection don't work, if that key is camelCase, because the glimmer-resolver does not provide a normalize method.

Because of this, the raw specifier is just passed through as is, and has fails.

validateInjections is stripped from prod builds and since the actual resolution works successfully (#206), this does not fail in production.

/cc @lolmaus @simonihmig
@buschtoens buschtoens mentioned this issue Dec 20, 2018
Closed
@buschtoens buschtoens changed the title MU resolver does not convert camelCase to kebap-case for has check``` MU resolver does not convert camelCase to kebap-case for has check Dec 20, 2018
@buschtoens buschtoens mentioned this issue Dec 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@buschtoens