Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MU: camelCased lookups #195

Closed
mixonic opened this issue Jun 15, 2017 · 2 comments
Closed

MU: camelCased lookups #195

mixonic opened this issue Jun 15, 2017 · 2 comments

Comments

@mixonic
Copy link
Member

mixonic commented Jun 15, 2017

Ensure the module unification resolver handles cases where:

export default Component.extend({
  someSession: inject.service()
});

Ember looks up someSession on the container as camelCase. This means we would require the normalization step for the resolver.

An alternative approach would be to dasherize the property name before calling lookup in Ember.

/cc @tmquinn

@stefanpenner
Copy link
Contributor

stefanpenner commented Jun 15, 2017

@mixonic I think in a perfect world, the service() descriptor would handle that.

@mixonic
Copy link
Member Author

mixonic commented Jul 10, 2017

Closed in #206

Doing this in Ember's current service injection system is tricky since the injections are part of metal but dasherize etc are not. I punted and simply implemented in this repo for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants