Update @embroider/* packages #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like something's still up |
|
New errors, so progress 😁 |
NullVoxPopuli
force-pushed
the
upgrade-embroider-deps
branch
from
93486bd
to
ef3482d
Compare
NullVoxPopuli
force-pushed
the
upgrade-embroider-deps
branch
from
ef3482d
to
bf8310a
Compare
|
looks like pnpm fixed it! |
chancancode
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm the renovate now
It looks like we're being hit by the fix that landed here
This fix never made it to 3.28.x, so... gonna look in to some options (and verify if the error I'm seeing locally is 100% related)
It's looking very likely tho:
https://github.com/emberjs/ember.js/pull/19878/files#diff-d65b34d5754853a3a9de19cede5d07be2c17465b8199c0694b76ca2cc02486b7R182