Skip to content

Commit

Permalink
Switch to pnpm. yarn@v1 can't be trusted
Browse files Browse the repository at this point in the history
  • Loading branch information
NullVoxPopuli authored and knownasilya committed Oct 27, 2023
1 parent 563f9a3 commit ae5cad8
Show file tree
Hide file tree
Showing 11 changed files with 16,495 additions and 17,290 deletions.
51 changes: 17 additions & 34 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,12 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 1
- uses: volta-cli/action@v4
- name: Install Dependencies
run: yarn install --frozen-lockfile
- name: Lint Addon
run: yarn lint
working-directory: addon
- name: Lint Test App
run: yarn lint
working-directory: test-app
- name: Lint Docs
run: yarn lint
working-directory: docs
- uses: wyvox/action-setup-pnpm@v3
- name: Lint
run: pnpm lint

test:
name: Tests
Expand All @@ -37,16 +28,14 @@ jobs:
node: ['16', '18']

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 1
- uses: volta-cli/action@v4
- uses: wyvox/action-setup-pnpm@v3
with:
node-version: ${{ matrix.node }}
- name: Install Dependencies
run: yarn install --frozen-lockfile
- name: Test
run: yarn test:ember --launch ${{ matrix.browser }}
run: pnpm test:ember --launch ${{ matrix.browser }}
working-directory: test-app

floating-dependencies:
Expand All @@ -61,14 +50,14 @@ jobs:
browser: [chrome, firefox]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 1
- uses: volta-cli/action@v4
- name: Install Dependencies
run: yarn install --no-lockfile --non-interactive
- uses: wyvox/action-setup-pnpm@v3
with:
pnpm-args: '--no-lockfile'
- name: Test
run: yarn test:ember --launch ${{ matrix.browser }}
run: pnpm test:ember --launch ${{ matrix.browser }}
working-directory: test-app

try-scenarios:
Expand Down Expand Up @@ -98,12 +87,10 @@ jobs:
allow-failure: true

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 1
- uses: volta-cli/action@v4
- name: Install Dependencies
run: yarn install --frozen-lockfile
- uses: wyvox/action-setup-pnpm@v3
- name: Test
env:
EMBER_TRY_SCENARIO: ${{ matrix.ember-try-scenario }}
Expand All @@ -116,14 +103,10 @@ jobs:
timeout-minutes: 20
needs: test
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 1
- uses: volta-cli/action@v4
with:
node-version: 16.x
- name: Install Dependencies
run: yarn install --frozen-lockfile
- uses: wyvox/action-setup-pnpm@v3
- name: Test
run: yarn test:ember
run: pnpm test:ember
working-directory: docs
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ This repo is divided into multiple packages using Yarn workspaces:

- `git clone <repository-url>`
- `cd ember-page-title`
- `yarn install`
- `pnpm install`

## Linting

Inside any of the packages you can run:

- `yarn lint`
- `yarn lint:fix`
- `pnpm lint`
- `pnpm lint:fix`

## Running tests

Expand Down
2 changes: 1 addition & 1 deletion RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Once the prep work is completed, the actual release is straight forward:
* First, ensure that you have installed your projects dependencies:

```sh
yarn install
pnpm install
```

* Second, ensure that you have obtained a
Expand Down
2 changes: 1 addition & 1 deletion docs/config/ember-cli-update.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"isBaseBlueprint": true,
"options": [
"--welcome",
"--yarn"
"--pnpm"
]
}
]
Expand Down
10 changes: 3 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,9 @@
"type": "git",
"url": "[email protected]:ember-cli/ember-page-title.git"
},
"workspaces": [
"addon",
"docs",
"test-app"
],
"scripts": {
"prepare": "cd addon && yarn build"
"lint": "pnpm --filter '*' lint",
"prepare": "cd addon && pnpm build"
},
"devDependencies": {
"@release-it-plugins/lerna-changelog": "^6.0.0",
Expand All @@ -19,7 +15,7 @@
},
"volta": {
"node": "16.20.2",
"yarn": "1.22.17"
"pnpm": "8.10.0"
},
"publishConfig": {
"registry": "https://registry.npmjs.org"
Expand Down
Loading

0 comments on commit ae5cad8

Please sign in to comment.