Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to plain library with explicitModules support #306

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Convert to plain library with explicitModules support #306

merged 1 commit into from
Sep 25, 2024

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Sep 25, 2024

  • Convert from an addon to a plain NPM library (no ember addon features are needed).
  • Add an optional third argument that allows you to explicitly pass in modules, rather than relying on a global AMD loader.

@ef4 ef4 added the breaking label Sep 25, 2024
@ef4 ef4 merged commit b318d36 into master Sep 25, 2024
@ef4 ef4 deleted the become-library branch September 25, 2024 18:06
This was referenced Sep 25, 2024
Closed
Closed
@SergeAstapov SergeAstapov mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ef4