Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps, drop node 6 #348

Merged
merged 3 commits into from
Nov 3, 2019
Merged

Bump deps, drop node 6 #348

merged 3 commits into from
Nov 3, 2019

Conversation

xg-wang
Copy link
Member

@xg-wang xg-wang commented Aug 16, 2019

No description provided.

Copy link
Member

rwjblue commented Aug 17, 2019

Seems good to me, do we need to be worried about multiple major versions in play within the app at once anymore?

@xg-wang
Copy link
Member Author

xg-wang commented Aug 17, 2019

@rwjblue I'm hoping to get #292 in, then any fastboot app should be safe.

For multiple major in browser only app it's no different than other addons. Unfortunately there's no perfect solution now.

The best way for app to guard is to install https://github.com/salsify/ember-cli-dependency-lint.

For addon authors if the addon depends on a specific version ember-fetch (or any other addon) functionality, there's always risk if not enforce a peer-dependency.

@xg-wang xg-wang merged commit 0cbc25b into ember-cli:master Nov 3, 2019
@xg-wang xg-wang deleted the breaking-deps branch November 3, 2019 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants