-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce top-level add-on requirement #290
Comments
cc @nlfurniss @xg-wang for visibility. |
dnalagatla
added a commit
to dnalagatla/ember-fetch
that referenced
this issue
May 3, 2019
dnalagatla
added a commit
to dnalagatla/ember-fetch
that referenced
this issue
May 3, 2019
dnalagatla
added a commit
to dnalagatla/ember-fetch
that referenced
this issue
May 4, 2019
xg-wang
added a commit
that referenced
this issue
Nov 27, 2019
…addon Added a check to enforce top-level dependency #290.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ember-fetch requires the add-on to be a top-level dependency for an application to provide support for Fastboot. This is documented here.
Ember-fetch should enforce the above requirement during the build time of an application if an add-on is using it as a transitive dependency. Recently, ember-data added a dependency on ember-fetch and if the application didn't include ember-fetch dependency, then fastboot failed to load the fetch module.
The text was updated successfully, but these errors were encountered: