Update watch-detector to 1.0.1 #9619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Sep 15, 2021
|
Thank you! |
backspace
added a commit
to cardstack/cardstack
that referenced
this pull request
Sep 28, 2021
This silences a warning related to watchman changing versioning schemes as documented here: ember-cli/ember-cli#9619 Invalid watchman found, version: [2021.08.02.00] did not satisfy [>= 3.0.0]. Visit https://ember-cli.com/user-guide/#watchman for more info.
|
@rwjblue It's quite an old one, but I encounter this after ugrading watchman, and running ember-cli-3.28.5. It seems like it was not backported to 3.28. That beeing said, I guess ember-cli fallback on an other watcher (NODE) (I don't quite know what I'm talking about). So I wonder if I could just ignore the warning, or if this is worth an other patch release to 3.28 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly because it includes a fix for this issue #9531