Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier to blueprint #9391

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Add prettier to blueprint #9391

merged 1 commit into from
Dec 7, 2020

Conversation

bmish
Copy link
Member

@bmish bmish commented Nov 30, 2020

Implements this RFC: https://github.com/emberjs/rfcs/blob/master/text/0628-prettier.md (emberjs/rfcs#628)

Changes included:

  • Installs prettier dev dependencies (package.json)
  • Updates lint scripts (package.json)
  • Adds plugin:prettier/recommended to .eslintrc.js
  • Creates new file .prettierrc.js
  • Adds .prettierrc.js to Node files override in .eslintrc.js
  • Adds .eslintcache to .eslintiginore
  • Creates new file .prettierignore (duplicate of .eslintignore)
  • Fixes prettier violations in blueprints and test fixtures

TODO:

  • update tests
  • manually test this
  • ensure ember-cli generated code has no prettier violations
  • update ember generate to run lint:fix to fix prettier violations in external blueprints? (RFC section)
  • manually update ember blueprints (components, controllers, etc) to fix prettier violations

@bmish bmish marked this pull request as ready for review November 30, 2020 19:10
@rwjblue
Copy link
Member

rwjblue commented Dec 7, 2020

update ember generate to run lint:fix to fix prettier violations in external blueprints? (RFC section)

We can tackle this separately I think.

@rwjblue rwjblue merged commit 59eadad into ember-cli:master Dec 7, 2020
@rwjblue
Copy link
Member

rwjblue commented Dec 7, 2020

Thank you @bmish!

simonihmig added a commit to simonihmig/ember-cli that referenced this pull request Dec 10, 2020
ember-cli#9391 added the `-cache` flag to the eslint script, so we should ignore the cache file.
simonihmig added a commit to simonihmig/ember-cli that referenced this pull request Dec 11, 2020
ember-cli#9391 added the `-cache` flag to the eslint script, so we should ignore the cache file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants