Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis.yml: use fast_finish instead of undocumented fail_fast #8943

Merged

Conversation

tniezurawski
Copy link
Contributor

fail_fast used in .travis.yml config for addons is undocumented and I'm not sure if it even works. Travis config online validator complains about it. The closest option to what we would like to achieve is fast_finish.

Closes: #8912

@tniezurawski
Copy link
Contributor Author

Build execution time has reached the maximum allowed time for your plan (60 minutes).

🤔 It took AppVeyor more than 1 hour to test everything. So we have a timeout... Is it happening a lot? What should I do?

@tniezurawski
Copy link
Contributor Author

tniezurawski commented Nov 27, 2019

@rwjblue Could you take a look at that?

@rwjblue rwjblue merged commit 92bfcc8 into ember-cli:master Dec 3, 2019
@tniezurawski tniezurawski deleted the 8912-use-fast-finish-in-travis branch December 4, 2019 08:53
bartocc added a commit to bartocc/ember-engines that referenced this pull request Feb 27, 2020
matrix and jobs are aliases
replace fail_fast with fast_finish (see ember-cli/ember-cli#8943)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of undocumented fail_fast TravisCI option
2 participants