Provide a compatibility section in addon READMEs #8286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
Dec 12, 2018
Turbo87
reviewed
Dec 17, 2018
|
I'd personally be happy with targetting this PR to be released with EmberCLI 3.7, which means that it would need to target the |
kennethlarsen
force-pushed
the
feature/compatibillity-section
branch
from
bf9f54a
to
e1f96f7
Compare
Turbo87
reviewed
Dec 27, 2018
Turbo87
approved these changes
Dec 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be helpful to add a compatibility section to addon READMEs suggesting to use a version of Ember that is no lower than two LTS's back.
Let me know what you think.