Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing cwd to be passed to testem without being overridden by ember-cli #7758

Merged
merged 2 commits into from
Apr 16, 2018

Conversation

arthirm
Copy link

@arthirm arthirm commented Apr 13, 2018

When ember-cli invokes testem it provides defaultOptions for testem to use as a fallback option. But currently, the fallback option from ember-cli is used as progOptions in testem. And since progOptions has higher priority than fileOptions, the cwd being set in the testem.js file of an ember app is being overridden by ember-cli's fallbackOption.

Solution is to add defaultOptions as a sibling to progOptions and fileOptions in testem. And ember-cli can set defaultOptions invoke testem.

Related work in testem is in the below PR.
testem/testem#1219

Previously this commit caused the tests to run in only 1 partition because when ember-cli was passing progOptions to testem, it didnt transform the option's property names like testPage to test_page which has partition information from ember exam. Hence by default it ran in 1 partition.
ember exam does not fail if it is asked to run in multiple partitions but it ran only in 1 partition.

Copy link
Contributor

@stefanpenner stefanpenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM. But I would like either @rwjblue or @Turbo87 to also sign-off, as last time I missed the issue which resulted in the regression.

@Turbo87
Copy link
Member

Turbo87 commented Apr 16, 2018

haven't had time yet to test it, but if we land it I would prefer to have it go through the usual beta cycle to avoid issues like last time 🤔

@stefanpenner
Copy link
Contributor

I'm good with beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants