remove blueprints that will be provided by: #4909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
code climate is going to love you for this! |
stefanpenner
force-pushed
the
addonified
branch
from
654e99c
to
792e34d
Compare
|
☔ The latest upstream changes (presumably #4915) made this pull request unmergeable. Please resolve the merge conflicts. |
stefanpenner
force-pushed
the
addonified
branch
from
792e34d
to
6cdb5f6
Compare
|
☔ The latest upstream changes (presumably #4920) made this pull request unmergeable. Please resolve the merge conflicts. |
* ember: emberjs/ember.js#12412 * ember-legacy-blueprint-addon: https://github.com/ember-cli/ember-cli-legacy-blueprints
stefanpenner
force-pushed
the
addonified
branch
from
6cdb5f6
to
5435d26
Compare
|
☔ The latest upstream changes (presumably #4692) made this pull request unmergeable. Please resolve the merge conflicts. |
This was referenced Oct 24, 2015
homu
added a commit
that referenced
this pull request
Oct 26, 2015
fix model relationship name generation It is not currently possible to generate a model with a relationship named differently from the model's name ([despite the help indicating it should be](https://github.com/ember-cli/ember-cli/blob/master/blueprints/model/HELP.md)) This patch brings the code's behavior in line with the docs. The blueprint part of this patch will be obsoleted if #4909 lands, so I've also PRed the changes to the blueprint in ED: emberjs/data#3885 (the arg-parsing-fix part of this patch is still needed to pass a distinct name, though)
4 tasks
|
obsoleted by #5648 |
homu
added a commit
that referenced
this pull request
Mar 28, 2016
Add ember-cli-legacy-blueprints as internal dependency and remove blueprints and tests This PR resolves #5631 and #4909 - [x] Add ember-cli-legacy-blueprints as internal dependency - [x] Remove blueprints provided by ember-cli-legacy-blueprints - [x] Remove unnecessary tests covered by ember-cli-legacy-blueprints - [x] Fix any tests affected by blueprint removal (help .json output, etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clearly without the blueprints we will have many test failures, once we depend on addonified ember, those may stop. We should still extract nice blueprint test helpers for the various extracted addons to use.