Skip to content
This repository has been archived by the owner on Oct 29, 2020. It is now read-only.

Update asset-compilation docs to cover Babel 6.X transpilation #141

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

BrianSipple
Copy link
Contributor

Following our move to Babel 6.X, I figured it would be useful take a stab at updating the JS Transpilation section of our Asset Compilation page.

I included some insight on babel-preset-env, targets, and how to configure each.

One thing that's omitted, though, is how some Babel features beyond the purview of babel-preset-env can still be controlled by passing options to the ember-cli-babel hash on the app object in ember-cli-build.js.

I can expand on the docs here to mention this, but I'm also wondering if it might be better to fully document those options in the ember-cli-babel README, and then just link to them from here.

Copy link
Contributor

@stefanpenner stefanpenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow thanks!


module.exports = function(defaults) {
var app = new EmberApp(defaults, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep this section and say "If you're still using ember-cli-babel 5, do it this way"? Is it reasonable to eliminate this section so soon after we switch to 6?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that being a concern, but my thinking was that keeping the link to the 5.x docs would be an adequate way to guide users who haven't upgraded yet.

Also, this is just my take, but I think one of the main use cases for this documentation, in particular, is to guide someone who's newer to Ember and give them an overall feel for Ember CLI. Thus, they're more likely to be on a newer version -- and we're more likely to help them by linking to relevant projects (in this case, ember-cli-babel) for more thorough documentation.

@kellyselden kellyselden merged commit f3c17e9 into ember-cli:master Feb 2, 2018
@kellyselden
Copy link
Member

Thanks. Sorry it took so long.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants