Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Babel 6 compatibility #69

Merged
merged 1 commit into from
Jun 18, 2016
Merged

Add Babel 6 compatibility #69

merged 1 commit into from
Jun 18, 2016

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jun 18, 2016

This PR adds a __esModule property to the shims to make it compatible with the AMD module transform in Babel 6.

/cc @stefanpenner @rwjblue

@rwjblue
Copy link
Member

rwjblue commented Jun 18, 2016

Seems good. I am curious if you could just do:

values._esModule = true;

Maybe that doesn't work for some reason though...

@rwjblue rwjblue merged commit e19158a into ember-cli:master Jun 18, 2016
@rwjblue
Copy link
Member

rwjblue commented Jun 18, 2016

Thanks @Turbo87!

@rwjblue
Copy link
Member

rwjblue commented Jun 18, 2016

Tagged as v0.1.2

@Turbo87 Turbo87 deleted the babel-6 branch June 18, 2016 14:20
@Turbo87
Copy link
Member Author

Turbo87 commented Jun 21, 2016

@rwjblue see https://github.com/babel/babel/blob/master/packages/babel-plugin-transform-es2015-modules-commonjs/src/index.js#L26-L28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Turbo87 @rwjblue