Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shims for getOwner and setOwner #41

Closed
wants to merge 1 commit into from
Closed

Added shims for getOwner and setOwner #41

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 18, 2016

Not sure if the module naming is correct? Should both methods go into the same module?

@rwjblue
Copy link
Member

rwjblue commented Jan 18, 2016

Let me check with the team about what we want the module paths to be...

@ghost
Copy link
Author

ghost commented Jan 31, 2016

@rwjblue any update possible?

@danmcclain
Copy link

Any movement on this @rwjblue?

@onlymejosh
Copy link

Any updates on this @rwjblue I see there is a failing build but it looks like travis has been removed from this project now?

@rwjblue rwjblue mentioned this pull request Jun 5, 2016
@rwjblue
Copy link
Member

rwjblue commented Jun 5, 2016

I'd say lets go with:

import get from 'ember-owner/get';
import set from 'ember-owner/set';

We will also need to PR against the open PR in ember moving these shims upstream...

@cibernox
Copy link
Contributor

cibernox commented Jun 6, 2016

@martndemus If you're busy I have some cycles to add this.

@ghost
Copy link
Author

ghost commented Jun 6, 2016

@cibernox Be my guest!

@cibernox
Copy link
Contributor

cibernox commented Jun 6, 2016

@martndemus Done #65

@rwjblue rwjblue closed this Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants